fix: unset should unset readOnly date field from custom input component #8192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
EoinFalconer
changed the title
|
No changes to documentation |
|
Component Testing Report Updated Jan 6, 2025 12:52 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 06 Jan 2025 12:55:53 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
snorrees
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This works well from my PoV!
Tested with the following input component, on the same document in two different windows to check multiplayer as well.
components: {
input: function T(props: DateInputProps) {
const [ro, setRo] = useState(false)
return (
<Stack space={2}>
{props.renderDefault({...props, readOnly: ro})}
<Button
text={`Make ${ro ? 'writable' : 'readOnly'}`}
onClick={() => setRo((r) => !r)}
/>
<Button text={`Unset field`} onClick={() => props.onChange(unset())} />
<Button
text={`Set field`}
onClick={() => props.onChange(set(new Date().toISOString().split('T')[0]))}
/>
</Stack>
)
},
}
The input now updates in readonly mode.
Also tested datetime (without the split on the set button)
(TIL: we dont store the date input if it is not valid, so typing garbage in the filed does not sync)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment if you create a custom input component for a
datetimefield or adatefield, and performunsetin the custom input component when the field isreadOnlythe value will not update on the field.This occurs because this looks like it stores a local value, and when the field is read only, the input renders a plain text field which never triggers
handleDatePickerInputChange.In this PR, I have removed the plain text field and used the propagated
readOnlyflag to instead achieve this in theDateTimeInputcomponentWhat to review
We think this is ok? I'm not sure of the reasons for using the
Textcomponent instead but this feels better to allow theDateTimeInputto be able to be read only, for usage in other scenarios too?Testing
Didn't add any tests for this, let me know if I should.
Notes for release
unset()inside customdatetimeinputcomponents will now shown the that the value has been unset in the Studio UI.