test(e2e): add discard action test #8196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Jan 6, 2025 1:38 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 06 Jan 2025 13:48:22 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
RitaDias
requested review from
cngonzalez,
a team and
pedrobonamin
and removed request for
a team
pedrobonamin
approved these changes
Jan 7, 2025
Comment on lines
+19
to
+23
| // Focus the publish button to trigger the tooltip showing the keyboard shortcut | ||
| page.getByTestId('action-publish').focus() | ||
|
|
||
| // There is a delay before the tooltip opens, let's explicitly wait for it | ||
| await page.waitForTimeout(300) |
There was a problem hiding this comment.
Is it necessary to focus on the publish action? Not sure why we need to wait for the tooltip to open.
If we need the timeout to wait until the change has been saved, I think it will be a good idea to validate that the Saved shows in the footer.
Or maybe we could we just depend on the following step page.getByTestId('action-publish').click() ?
There was a problem hiding this comment.
That is a good question, I added this as a copy paste straight of the publish test (since I needed the document to be published) so I didn't even pass my eyes over it 🤔
That being said, let me have a look, I'll change the publish test too. good catch!
There was a problem hiding this comment.
(I think it wiser to not rely on the following step just by itself simply because I don't want to add more areas of potential flakiness which we know sometimes can happen in steps like those)
|
Actually, closing this since I just now realised (when looking through the feedback given by Pedro) that we already have some discard (DiscardChanges) tests. It just wasn't where I expected. One of the tests there already tests this use case, so I'm closing this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e test for the discard document action
What to review
Does the test make sense, should we implement it in a different way?
Notes for release
N/A, it's internal testing