-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for profiling CLI commands through SANITY_DEBUG_PROFILING #8201
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Component Testing Report Updated Jan 7, 2025 11:48 AM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 07 Jan 2025 11:50:59 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
c594f75
to
d4390fa
Compare
I need some clarification on how to test this manually, sorry if this is obvious. Because I did this but I wasn't able to find the cpu profile file, so I'm guess I did something wrong 😅 |
Description
This adds support for a new environment variable (
SANITY_DEBUG_PROFILING=<DIRECTORY>
) which runs all the worker commands (schema extract
,manifest extract
etc) under the V8 profiler and dumps it for further inspection.What to review
Further testing that it works not only on my machine would be nice.
Testing
I've tested it manually on a real-world Studio by running
npm link ../sanity/packages/sanity
and invoking the command.Notes for release
Not required (I think).