You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It also modifies the config flag we have added for the events api and enables it by default for documents events for all the studios.
It's kept as a flag in case we need to turn it off.
Releases events are not ready to be used by everyone yet, so a new flag has been added to handle this. It will be enabled by default in the playground studio.
It also updates the sort algorithm for the events, given the timestamp validation is not the only check necessary, because edit and publish events now have the same timestamp and the order was incorrect.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
39ms
41ms
52ms
257ms
174ms
9.8s
article (body)
13ms
15ms
26ms
147ms
213ms
5.2s
article (string inside object)
36ms
37ms
39ms
72ms
140ms
6.5s
article (string inside array)
43ms
46ms
52ms
190ms
245ms
7.0s
recipe (name)
20ms
22ms
24ms
44ms
0ms
7.4s
recipe (description)
18ms
19ms
21ms
23ms
0ms
4.4s
recipe (instructions)
5ms
7ms
8ms
12ms
0ms
3.1s
synthetic (title)
52ms
54ms
61ms
135ms
726ms
12.5s
synthetic (string inside object)
52ms
55ms
68ms
471ms
1084ms
8.6s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
37ms
43ms
48ms
529ms
316ms
13.0s
article (body)
15ms
17ms
21ms
75ms
61ms
5.0s
article (string inside object)
38ms
40ms
42ms
71ms
160ms
7.0s
article (string inside array)
43ms
45ms
51ms
63ms
229ms
7.1s
recipe (name)
16ms
19ms
21ms
39ms
0ms
7.4s
recipe (description)
17ms
17ms
20ms
28ms
0ms
4.5s
recipe (instructions)
6ms
7ms
9ms
19ms
0ms
3.1s
synthetic (title)
48ms
53ms
86ms
213ms
840ms
13.3s
synthetic (string inside object)
47ms
49ms
50ms
89ms
209ms
7.6s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the events api routes that we were using.
The routes now will be:
data/history/{datasetName}/events/documents/{ids}
data/history/{datasetName}/events/releases/{id}
It also modifies the config flag we have added for the events api and enables it by default for documents events for all the studios.
It's kept as a flag in case we need to turn it off.
Releases events are not ready to be used by everyone yet, so a new flag has been added to handle this. It will be enabled by default in the
playground
studio.It also updates the sort algorithm for the events, given the timestamp validation is not the only check necessary, because edit and publish events now have the same timestamp and the order was incorrect.
What to review
Testing
Notes for release