Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
I think a better long-term solution is to implement a CRC on the first 8 KiB + database lookup for SMS/GG/SG-1000 to determine the correct ROM size (or something similar to how NES/Famicom auto mapper detection works). This is especially true as not all carts have the "TMR SEGA" header value. For now, this update allows for anyone to manually specify the ROM size regardless of the detection algorithm being invoked to address edge cases.
Testing (HW5):
I've tested manual setting of ROM size on the problematic carts:
Tested working auto-detect US SMS carts: