replace cart selection code of A7800 with one used at NES, COLV, INTV, WSV #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 24, 2024 19:55
|
With latests commits, it looks like errors/warnings are now displayed when I try to compile the project with hw5 + lot of systems selected. Could be due to "&readDataLine_ARC" in the A2600 module @smesgr9000 can you try to put your compiler warning option to "All" and have a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please review #934 first. This one extends on this change.
This pull requests replaces the cart selection code of 7800 with the afaik more user friendly code of NES, COLV, INTV & WSV. Plus due to the code similarities the used space of the program is reduced in my configuration from
243718 to 242794 Bytes
Downside the cart database structure for the 7800 must be changed. If some user only update the firmware without the SD card - cart selection does not work until SD card is updated.
If this is ok - I would like to change 2600 and C64 as well.