This repository has been archived by the owner on May 29, 2020. It is now read-only.
Add ligature support to Node engine #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces ligature support to the Node engine by updating `svgicons2svgfont` to v8.0.0.
This was referenced Dec 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
svgicons2svgfontadded support for ligatures several versions ago,grunt-webfontstill depends on v1.1.0 (see #251) - so the Node engine is unable to support ligatures. This PR updates to the current (at time of writing) version - v8.0.0 - and passes through the relevant metadata to generate ligatures (if theligaturesoption is enabled).I haven't updated the readme in this PR; if you'd like me to include such an update, please let me know what version number you'd release this change in (so that I can list ligatures as supported in the Node engine from that version onwards).
Closes #251