Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint config and dependencies #732

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

favna
Copy link
Member

@favna favna commented Apr 7, 2024

Important

Rebase & Merge

Important

Depends on typescript-eslint/typescript-eslint#8211 being fully resolved. In particular RuleTester from @typescript-eslint/rule-tester currently does not support flat config. RESOLVED

This pull request updates the eslint config and dependencies for this repository.

TODO:

  • Updated eslint to version 9 and switched to a flat config system.
  • Updated the code to use the new eslint config.
  • Update the eslint-plugin-result to ESLint v9
  • Wait for a stable release of typescript-eslint v8 and drop the alpha install
  • Clean up the commits for a clean rebase & merge

favna added 5 commits May 28, 2024 23:57
BREAKING CHANGE: This package now only exports a flat config. For more information see the [eslint migration guide](https://eslint.org/blog/2024/04/eslint-v9.0.0-released) and [flat config guide](https://eslint.org/blog/2022/08/new-config-system-part-2/). The README of this package has instructions for how to use this package with the new flat config system.
BREAKING CHANGE: This plugin now requires eslint v9 or higher. For more information see the [eslint migration guide](https://eslint.org/blog/2024/04/eslint-v9.0.0-released) and [flat config guide](https://eslint.org/blog/2022/08/new-config-system-part-2/). The README of this package has instructions for how to use this package with the new flat config system.
@favna favna force-pushed the feat/update-to-eslint-v9-flat-config branch from 2c27112 to baebc7b Compare May 28, 2024 22:01
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 89.15663% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 57.50%. Comparing base (dda47af) to head (b687c68).

Files Patch % Lines
packages/eslint-plugin-result/src/index.ts 0.00% 36 Missing ⚠️
...es/eslint-plugin-result/src/configs/recommended.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   57.53%   57.50%   -0.03%     
==========================================
  Files         231      231              
  Lines       18334    18385      +51     
  Branches     1296      816     -480     
==========================================
+ Hits        10548    10572      +24     
- Misses       7781     7808      +27     
  Partials        5        5              
Flag Coverage Δ
18 57.50% <89.15%> (-0.03%) ⬇️
19 57.50% <89.15%> (-0.03%) ⬇️
20 57.50% <89.15%> (-0.03%) ⬇️
21 57.50% <89.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 89.15663% with 45 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (dda47af) to head (b687c68).
Report is 149 commits behind head on main.

Files with missing lines Patch % Lines
packages/eslint-plugin-result/src/index.ts 0.00% 36 Missing ⚠️
...es/eslint-plugin-result/src/configs/recommended.ts 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   57.53%   57.50%   -0.03%     
==========================================
  Files         231      231              
  Lines       18334    18385      +51     
  Branches     1296      816     -480     
==========================================
+ Hits        10548    10572      +24     
- Misses       7781     7808      +27     
  Partials        5        5              
Flag Coverage Δ
18 57.50% <89.15%> (-0.03%) ⬇️
19 57.50% <89.15%> (-0.03%) ⬇️
20 57.50% <89.15%> (-0.03%) ⬇️
21 57.50% <89.15%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants