Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vms x86 #108

Merged
merged 12 commits into from
May 15, 2024
Merged

Vms x86 #108

merged 12 commits into from
May 15, 2024

Conversation

whcox603
Copy link
Contributor

@whcox603 whcox603 commented May 15, 2024

I did this port of the library to vms_x86 about 6 months ago. Not many changes. I did rewrite the vms_build procedure. I held off requesting a merge to await a fix for the 3 failing tests. I commented in a group somewhere and got a reply from a developer that sounded like it would be fixed in the next release, but I was not able to confirm the fix. I also noted that the one new test failure was due to C and C++ disagreeing on sizes.

My VMS_x86 license expired a month ago and I am still awaiting a new license.

Feel free to reject this if you have already done the port.

bill

@saprykin
Copy link
Owner

Hi Bill,

Thanks for PR. I'm actually working on VMS x86 port in the last days :) Looking into the long size issue right now, the rest was quite trivial. I did not do much changes in build_vms.com, though, maybe a few lines. I suggest that I merge my changes into your PR, as most of them are common. I have only access to Alpha and x86 in emulators, cannot test on IA64.

Did IEEE floating denormalisation cause any issues on x86?

@whcox603
Copy link
Contributor Author

Alexander,

The only test issues I had were the 3 that were already failing, plus the one caused by the size mismatch.

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@saprykin saprykin merged commit 6fe14a1 into saprykin:master May 15, 2024
2 of 6 checks passed
@whcox603
Copy link
Contributor Author

whcox603 commented May 16, 2024 via email

@saprykin
Copy link
Owner

Do the 3 tests still fail on vms?

Yes. The only difference is that semaphore test passes one time when compiled with 32-bit pointers. Each next time it fails.

@whcox603 whcox603 deleted the VMS_x86 branch May 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants