Merge pull request #20 from sarchlab/19-dram-latency-is-reported-as-0

Fix the bug that DRAM tracer always report 0 as latency
sarchlab · Dec 2, 2023 · 384714c · 384714c
2 parents 37c5609 + 709bae4
commit 384714c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -160,12 +160,8 @@
             "args": [
                 "-timing",
                 "-length=64",
-<<<<<<< HEAD
                 "-report-all",
             ],
-=======
-            ]
->>>>>>> a4c4159dfeef26022d3c97e9ac583fabf5c1d2bd
         },
         {
             "name": "Conv2d",

diff --git a/samples/runner/dramtracer.go b/samples/runner/dramtracer.go
@@ -11,6 +11,7 @@ import (
 // dramTracer can trace DRAM activities.
 type dramTracer struct {
 	sync.Mutex
+	sim.TimeTeller
 
 	inflightTasks map[string]tracing.Task
 
@@ -22,8 +23,9 @@ type dramTracer struct {
 	writeSize       uint64
 }
 
-func newDramTracer() *dramTracer {
+func newDramTracer(timeTeller sim.TimeTeller) *dramTracer {
 	return &dramTracer{
+		TimeTeller:    timeTeller,
 		inflightTasks: make(map[string]tracing.Task),
 	}
 }
@@ -33,6 +35,8 @@ func (t *dramTracer) StartTask(task tracing.Task) {
 	t.Lock()
 	defer t.Unlock()
 
+	task.StartTime = t.TimeTeller.CurrentTime()
+
 	t.inflightTasks[task.ID] = task
 }
 
@@ -51,6 +55,7 @@ func (t *dramTracer) EndTask(task tracing.Task) {
 		return
 	}
 
+	task.EndTime = t.TimeTeller.CurrentTime()
 	taskTime := task.EndTime - originalTask.StartTime
 
 	switch originalTask.What {

diff --git a/samples/runner/report.go b/samples/runner/report.go
@@ -316,7 +316,7 @@ func (r *Runner) addDRAMTracer() {
 		for _, dram := range gpu.MemControllers {
 			t := dramTransactionCountTracer{}
 			t.dram = dram.(TraceableComponent)
-			t.tracer = newDramTracer()
+			t.tracer = newDramTracer(r.platform.Engine)
 
 			tracing.CollectTrace(t.dram, t.tracer)