Support a Separate GMMU Page Table #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuWei-CH
commented
Nov 1, 2024
YuWei-CH
commented
- Get VAddrToPageMapping from driver/internal/memoryallocator.go
- Iterate VAddrToPageMapping in RegisterGPU to store the page in GMMU's page table
syifan
reviewed
Nov 6, 2024
| @@ -17,6 +17,7 @@ type Builder struct { | |||
| useMagicMemoryCopy bool | |||
| middlewareD2HCycles int | |||
| middlewareH2DCycles int | |||
| memorySize uint64 | |||
There was a problem hiding this comment.
Can we name this one as cpuMemorySize to avoid confusion?
| @@ -74,6 +75,12 @@ func (b Builder) WithH2DCycles(h2dCycles int) Builder { | |||
| return b | |||
| } | |||
|
|
|||
| // WithMemorySize sets the memory size of the CPU. | |||
| func (b Builder) WithMemorySize(memorySize uint64) Builder { | |||
There was a problem hiding this comment.
Same here, since this is for CPU, can we just say WithCPUMemorySize?
| d.devices = append(d.devices, gpuDevice) | ||
|
|
||
| for _, page := range d.memAllocator.GetVAddrToPageMapping() { |
There was a problem hiding this comment.
Is this required? I think, at the beginning, no page has already been allocated.
| @@ -455,6 +462,9 @@ func (d *Driver) distributeWGToGPUs( | |||
| panic("not all wg allocated") | |||
| } | |||
|
|
|||
| // fmt.Sprintln("total WG: %d WG Per CU %d\n", totalWGCount, wgPerCU) | |||
| fmt.Printf("total WG: %d WG Per CU %d\n", totalWGCount, wgPerCU) | |||
| a.Lock() | ||
| defer a.Unlock() | ||
| copy := make(map[uint64]vm.Page, len(a.vAddrToPageMapping)) | ||
| for vAddr, page := range a.vAddrToPageMapping { |
There was a problem hiding this comment.
About empty lines. Please consider these general rules. 1. Add an empty line after defer. 2. Add an empty line before if and for. 3 Add an empty line before return.
| if b.perfAnalyzer != nil { | ||
| b.perfAnalyzer.RegisterComponent(cp) | ||
| } | ||
| // if b.perfAnalyzer != nil { |
There was a problem hiding this comment.
Is there some problem with perfAnalyzer? If not, let's do not comment it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.