initial accelsim traing branch #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😮I think the lint test isn't working, I definitely cannot pass. |
Actually, all the tests passed. So, there is no linting issue. |
syifan
requested changes
Dec 2, 2023
|
@gongchen618 Since this is a PR that only adds new code, should I just merge it, and let's talk about how to improve it later? |
Separate RDMA Tracing to Inside and Outside
Lets talk! I myself also have some coding problems that I keep doubting how to solve and I need your help 😿 |
syifan
reviewed
Dec 6, 2023
syifan
reviewed
Dec 6, 2023
syifan
reviewed
Dec 6, 2023
syifan
previously approved these changes
Dec 6, 2023
gongchen618
dismissed
syifan’s stale review
The merge-base changed after approval.
syifan
approved these changes
Dec 6, 2023
syifan
approved these changes
Dec 6, 2023
syifan
previously approved these changes
Dec 6, 2023
gongchen618
dismissed
syifan’s stale review
The merge-base changed after approval.
syifan
previously approved these changes
Dec 13, 2023
gongchen618
dismissed
syifan’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did some refactor, make the trace data flow through, no output