Redirect debugging

[danfunk]

Assure we always generated the redirect with the same exact peice of code. And debug the value that is used in that location

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error handling for missing ID tokens during login.
  • Improved clarity in error categorization.

• New Features

  • Streamlined token management and redirect URL handling during authentication.

• Tests

  • Updated test parameters and assertions to align with changes in state generation.

• Chores

  • Modified .gitignore to adjust directory tracking for process_models.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces modifications primarily to the authentication_controller.py and authentication_service.py files, focusing on enhancing error handling and streamlining token management during the authentication process. Key changes include the renaming of error codes for clarity, adjustments to method signatures to eliminate redundant parameters, and updates to the handling of redirect URLs. The test suite has also been updated to reflect these changes. Additionally, a minor update to the .gitignore file was made to change the reference for the process_models directory.

Changes

File	Change Summary
spiffworkflow-backend/src/spiffworkflow_backend/routes/authentication_controller.py	- Updated error code from invalid_token to missing_token. - Simplified login and login_api functions by removing state and redirect_url constructions. - Modified login_return to extract final_url instead of redirect_url. - Updated method signatures for login_return, login_api, and login_api_return to remove unnecessary parameters.
spiffworkflow-backend/src/spiffworkflow_backend/services/authentication_service.py	- Updated generate_state method to use final_url instead of redirect_url. - Adjusted get_login_redirect_url to remove redirect_url parameter and utilize the new state generation logic. - Added debug logging for constructed redirect URL. - Updated method signatures accordingly.
spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_authentication.py	- Modified test_get_login_state to change parameter order in generate_state method and updated assertions to check for final_url.
.gitignore	- Changed entry for process_models/ to process_models, removing the trailing slash.

Possibly related PRs

• be consistent about how the redirect uri is generated. #2153: The changes in this PR involve the get_login_redirect_url method, which is directly related to the modifications made in the main PR regarding how redirect URLs are handled during authentication.

Suggested reviewers

• burnettk

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad03fce and b961e5d.

📒 Files selected for processing (1)

• .gitignore (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• .gitignore

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.