fix test server setup: #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- go map access is not deterministic - this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors - registering handlers now converts * in routes to .* for proper regex matching - test server route handling now tries to fully match the handler route
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
+ Coverage 97.85% 97.88% +0.02%
==========================================
Files 20 20
Lines 978 991 +13
==========================================
+ Hits 957 970 +13
Misses 15 15
Partials 6 6 |
|
Thank you for the PR! |
sashabaranov
reviewed
Nov 9, 2023
| @@ -42,7 +42,7 @@ func TestFineTuningJob(t *testing.T) { | |||
| ) | |||
|
|
|||
| server.RegisterHandler( | |||
| "/fine_tuning/jobs/"+testFineTuninigJobID+"/cancel", | |||
| "/v1/fine_tuning/jobs/"+testFineTuninigJobID+"/cancel", | |||
There was a problem hiding this comment.
Why do we need to add v1 here?
sashabaranov
approved these changes
Nov 9, 2023
maerlyn5
pushed a commit
to prassoai/go-openai
that referenced
this pull request
Nov 22, 2023
* fix test server setup: - go map access is not deterministic - this can lead to a route: /foo/bar/1 matching /foo/bar before matching /foo/bar/1 if the map iteration go through /foo/bar first since the regex match wasn't bound to start and end anchors - registering handlers now converts * in routes to .* for proper regex matching - test server route handling now tries to fully match the handler route * add missing /v1 prefix to fine-tuning job cancel test server handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes testing less flaky