Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenAI reasoning models #850

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

abatilo
Copy link
Contributor

@abatilo abatilo commented Sep 12, 2024

@abatilo
Copy link
Contributor Author

abatilo commented Sep 12, 2024

@sashabaranov what do you think?

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (774fc9d) to head (b6155c8).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   98.46%   99.01%   +0.55%     
==========================================
  Files          24       26       +2     
  Lines        1364     1422      +58     
==========================================
+ Hits         1343     1408      +65     
+ Misses         15        8       -7     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I believe we'll need to update the disabledModelsForEndpoints enum in the same file as well

@kainosnoema
Copy link

Will also need to merge #851

@jackmcguire1
Copy link

Bump

@sashabaranov
Copy link
Owner

@abatilo would you be able to update the PR?

@abatilo
Copy link
Contributor Author

abatilo commented Sep 17, 2024

Sorry for the delay @sashabaranov. I've updated the map as requested!

@sashabaranov sashabaranov merged commit a5fb553 into sashabaranov:master Sep 17, 2024
1 check passed
@yash15112001
Copy link

Thank You!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants