fix: jsonschema integer validation #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 98.46% 99.01% +0.55%
==========================================
Files 24 26 +2
Lines 1364 1422 +58
==========================================
+ Hits 1343 1408 +65
+ Misses 15 8 -7
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Thank you for the PR! Looks good, and here's a minimal example validating the float64 argument https://go.dev/play/p/VRMIyt9Zjqz |
jsonschema/validate_test.go
Outdated
| @@ -94,6 +94,10 @@ func TestUnmarshal(t *testing.T) { | |||
| String string `json:"string"` | |||
| Number float64 `json:"number"` | |||
| } | |||
| var result3 struct { | |||
There was a problem hiding this comment.
Could we maybe inline all these result1,2,3 please?
WeiAnAn
force-pushed
the
fix/jsonschema-integer-validation
branch
from
f1be751 to
7831bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Fix the jsonschema validation failed failure on the integer field.
Provide OpenAI documentation link
Describe your solution
Follow the #837 instruction. Because go unmarshalls all numbers as float64, we should check the value is an integer.
Tests
Add
jsonschema.Integercases, include a success and a failed case.Additional context
Add any other context or screenshots or logs about your pull request here. If the pull request relates to an open issue, please link to it.
Issue: #837