Support deprecation options in the legacy JS API #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Jul 30, 2024
lib/src/legacy/index.ts
Outdated
| @@ -156,7 +156,6 @@ function convertOptions<sync extends 'sync' | 'async'>( | |||
| ), | |||
| ] | |||
| : undefined; | |||
|
|
|||
nex3
approved these changes
Aug 22, 2024
ntkme
reviewed
Sep 3, 2024
jest.config.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| const config = { | |||
| preset: 'ts-jest', | |||
| testEnvironment: 'node', | |||
| modulePathIgnorePatterns: ['<rootDir>/dart-sass/'], | |||
There was a problem hiding this comment.
I had a similar but different commit to fix this issue: 01d7e42
Not sure which way is preferred.
There was a problem hiding this comment.
Yeah, your solution looks better. I'll just add it to this PR for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3907.
See sass/sass-spec#2006.
See sass/dart-sass#2293.