Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Color 4] Add tests for lab() #1928

Merged
merged 2 commits into from
Sep 28, 2023
Merged

[Color 4] Add tests for lab() #1928

merged 2 commits into from
Sep 28, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jul 28, 2023

This still needs error output, but Dart Sass currently doesn't support
missing alpha channels or the is-missing() function so they can't be
generated yet.

See sass/sass#2831

[skip dart-sass]

@nex3 nex3 marked this pull request as ready for review September 22, 2023 23:39
@nex3 nex3 requested review from Goodwine and removed request for jathak September 26, 2023 20:57
a {b: lab(1px 2 3)}

<===> unit/lightness/error
Error: $lightness: Expected 1px to have no units or "%".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: unrelated to the change, but when I read "expected 1px have no units or %" It makes me think that the number shouldn't have units and that it also shouldn't have percent (some users might not think of percent as a unit).

So I wonder if that could be reworded (maybe on a separate PR?) to something like.. Expected 1px to have no units or to have "%". or Expected 1px to have "%" or no units. or something like that 🤔

@nex3 nex3 merged commit b03c91e into feature.color-4 Sep 28, 2023
12 checks passed
@nex3 nex3 deleted the lab branch September 28, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants