Update deprecations tests to use YAML list #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a good way to make the YAML file accessible to tests running in a browser, so we can just skip them there.
nex3
approved these changes
May 22, 2024
| }; | ||
| const obsoleteDeprecations: {[key: string]: [string, string]} = {}; | ||
| const activeDeprecations: {[key: string]: string} = {}; | ||
| const futureDeprecations: {[key: string]: true} = {}; |
There was a problem hiding this comment.
It's probably cleaner to use a Set for this.
| const deprecation = deprecationsMap[id]; | ||
| expect(deprecation?.id).toBe(id); | ||
| expect(deprecation?.status).toBe('obsolete'); | ||
| expect(deprecation?.deprecatedIn).toEqual(Version.parse(deprecatedIn)); |
There was a problem hiding this comment.
Might be worth adding a comment here to the effect that if we ever have a JS API backed by a non-Dart-Sass implementation, it may have different versions for these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3872.