Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Minitest module instead of MiniTest compatibility layer #242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use Minitest module instead of MiniTest compatibility layer #242

wants to merge 2 commits into from

Commits on Sep 2, 2023

  1. Use Minitest module instead of MiniTest compatibility layer 

    The Minitest package has long been capitalized like that. The variant
MiniTest is retained only as a compatibility layer. Switch to the
current module name.

This change is motivated by Fedora, which already uses minitest 5.19.
That version requires setting the env variable MT_COMPAT to import the
compatibility module, and thus revealed the problem in Fedora build
system.

Signed-off-by: Otto Liljalaakso <otto.liljalaakso@iki.fi>
    @oturpe
    oturpe committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    6a59496 View commit details
    Browse the repository at this point in the history

  2. Allow newer minitest versions 

    sassc-ruby build in Fedora ignores the dependency version constaints
given in gemspec and uses the versions included in the Fedora
distribution. Currently, Fedora is on 5.19.0, which works. Based on
this, the version constaint can be considerably relaxed.

Signed-off-by: Otto Liljalaakso <otto.liljalaakso@iki.fi>
    @oturpe
    oturpe committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    e44a8b1 View commit details
    Browse the repository at this point in the history