Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for K8S 1.30 (PSKD-518) #564

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat: add support for K8S 1.30 (PSKD-518) #564

merged 1 commit into from
Jul 30, 2024

Conversation

joshhames
Copy link
Contributor

@joshhames joshhames commented Jul 29, 2024 •
edited
Loading

Updated files necessary to change kubectl version to 1.29.7 in support of K8S 1.30.

Changes:

This PR updates the default version of kubectl to add support for K8s 1.30

  • Default kubectl version is updated to 1.29.7

Tests:

Verified following scenarios, see internal ticket for details.

Scenario Task Provider Cadence kubernetes_version Deploy method Notes
1 OOTB Azure stable:2024.07 1.28 docker, DO: false
2 OOTB Azure stable:2024.07 1.29 docker, DO: false New default kubectl
3 OOTB Azure stable:2024.07 1.30 ansible, DO: true Overwrite kubectl version in the DO

@joshhames joshhames changed the base branch from main to staging July 29, 2024 19:02
ephesused
ephesused reviewed Jul 29, 2024
View reviewed changes
Copy link

@ephesused ephesused left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm new in this space - I'll defer the approvals to others.

dhoucgitter
dhoucgitter approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@dhoucgitter dhoucgitter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Added Changes and Tests documentation looks good.

@joshhames joshhames self-assigned this Jul 30, 2024
@joshhames joshhames merged commit de5c139 into staging Jul 30, 2024
3 checks passed
@joshhames joshhames deleted the PSKD-518 branch July 30, 2024 00:54
@dhoucgitter dhoucgitter mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephesused ephesused ephesused left review comments

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@ndickens ndickens Awaiting requested review from ndickens

@jarpat jarpat Awaiting requested review from jarpat

Assignees

@joshhames joshhames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshhames @dhoucgitter @ephesused