Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (PSKD-957) ingress-nginx configmap changes for v1.12+ #586

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Dec 12, 2024

Changes

  • Add one or two config map values as required to maintain the default values they had prior to ingress-nginx v1.12
  • ingress-nginx v1.12.0 has changed the defaults for those two config map values, the values required by the Viya platform differ from the new defaults.

Tests

A set of the tests below will be spot checked when the ingress-nginx v1.12.0 helm chart is available and updated in the related internal ticket for that purpose.

Development tests

Scenario Provider K8s version ingress-nginx chart version Cadence relevant ingress-nginx config map values set Notes
1 Azure 1.30 4.11.1 stable:2024.11 None No additional cm value set for 2024.11 cadence
2 Azure 1.30 4.11.1 stable:2024.08 None No additional cm value set for 2024.08 cadence
3 Azure 1.30 4.11.1 stable:2024.12 None No additional cm value set for 2024.12 cadence
4 Azure 1.30 4.11.1 fast:2020 None No additional cm value set for fast:2020 cadence
5 Azure 1.30 4.11.1 lts:2024.03 None No additional cm value set for lts:2024.03 cadence
6 Azure 1.30 4.11.3 * lts:2024.03 strict-validate-path-type: 'false';annotations-risk-level: Critical Expected 2 cm values set for lts:2024.03 cadence and stand-in for ingress-nginx v1.12.0
7 Azure 1.30 4.11.3 * stable:2024.12 annotations-risk-level: Critical Expected cm value set for stable:2024.12 cadence and stand-in for ingress-nginx v1.12.0
8 Azure 1.30 4.11.3 * stable:2024.11 strict-validate-path-type: 'false';annotations-risk-level: Critical Expected 2 cm values set for lts:2020.03 cadence and stand-in for ingress-nginx v1.12.0
  • For the development tests 6-8, chart version v4.11.3 was used as a stand in for the upcoming v4.12.0 to verify config map values are being set based on the latest ingress-nginx version, ingress-nginx version comparison value was adjusted in the dev branch after completing those tests.

Signed-off-by: David.Houck <David.Houck@sas.com>
@dhoucgitter dhoucgitter added the enhancement New feature or request label Dec 12, 2024
@dhoucgitter dhoucgitter self-assigned this Dec 12, 2024
Signed-off-by: David.Houck <David.Houck@sas.com>
Signed-off-by: David.Houck <David.Houck@sas.com>
Signed-off-by: David.Houck <David.Houck@sas.com>
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhoucgitter dhoucgitter merged commit 18575d2 into staging Dec 17, 2024
4 checks passed
@dhoucgitter dhoucgitter deleted the PSKD-957 branch December 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants