Avoid leaking ssl_fd on every new SSL connection #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes a memory leak when running tcpkali with
--ssl. The SSL structure created bySSL_newinssl_setupwere not being freed anywhere, so in a long-running process with a lot of new connections it was possible to leak quite a lot of memory.We are running tcpkali with
--ssl -c10kand a multi-day-T, and without this patch we see it consuming gigabytes of RAM after a couple of mass reconnections. With this patch its memory usage is steady across reconnections. This graph shows the difference we see: