Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fixed Segmentation fault errors #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

navimakarov
Copy link
Contributor

@navimakarov navimakarov commented Dec 1, 2018

Fixed errors from issue #84

@codecov
Copy link

codecov bot commented Dec 1, 2018

Codecov Report

Merging #85 into master will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   42.46%   42.47%   +<.01%     
==========================================
  Files          27       27              
  Lines        3478     3480       +2     
==========================================
+ Hits         1477     1478       +1     
- Misses       2001     2002       +1
Impacted Files Coverage Δ
src/lib_ccaligner/read_wav_file.cpp 31.98% <50%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3fea1e...357b52c. Read the comment docs.

@saurabhshri
Copy link
Owner

Please link the issue for which this fix is. :)

@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue #8 [FIX] fixed Segmentation fault errors from issue [#8( https://github.com/saurabhshri/CCAligner/issues/84) Dec 2, 2018
@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue [#8( https://github.com/saurabhshri/CCAligner/issues/84) [FIX] fixed Segmentation fault errors from issue [#8](https://github.com/saurabhshri/CCAligner/issues/84) Dec 2, 2018
@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue [#8](https://github.com/saurabhshri/CCAligner/issues/84) [FIX] fixed Segmentation fault errors from issue Dec 2, 2018
@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue [FIX] fixed Segmentation fault errors from issue Dec 2, 2018
@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue [FIX] fixed Segmentation fault errors from issue #84 Dec 2, 2018
@navimakarov navimakarov changed the title [FIX] fixed Segmentation fault errors from issue #84 [FIX] fixed Segmentation fault errors Dec 2, 2018
@saurabhshri
Copy link
Owner

Hello @navimakarov ! Thanks for the PR. Sorry for being inactive about this,I got caught up at work. Do you still want to work on getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants