Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migration to ktlint v1 #1736

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 19, 2023

What's done:

  • supported artifact names changes
  • logging upgrades
  • disabled tests which fails with repeatable run
  • fixed test for comment when ASTNode.copy() is called

@nulls nulls added this to the 2.0.0 milestone Sep 19, 2023
@nulls nulls self-assigned this Sep 19, 2023
@github-actions
Copy link
Contributor

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   7m 15s ⏱️
1 377 tests 1 305 ✔️ 36 💤 36
2 756 runs  2 683 ✔️ 36 💤 37

For more details on these failures, see this check.

Results for commit 9cd867d.

@github-actions
Copy link
Contributor

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files     164 suites   8m 13s ⏱️
1 377 tests 1 321 ✔️ 17 💤 39
2 756 runs  2 699 ✔️ 17 💤 40

For more details on these failures, see this check.

Results for commit 9cd867d.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (renovate/major-ktlint@c0a34d9). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             renovate/major-ktlint    #1736   +/-   ##
========================================================
  Coverage                         ?   74.76%           
  Complexity                       ?     2270           
========================================================
  Files                            ?      126           
  Lines                            ?     8230           
  Branches                         ?     2072           
========================================================
  Hits                             ?     6153           
  Misses                           ?     1163           
  Partials                         ?      914           

@nulls nulls marked this pull request as ready for review September 20, 2023 08:38
@nulls nulls merged commit bd0dc32 into renovate/major-ktlint Sep 20, 2023
24 checks passed
@nulls nulls deleted the feature/renovate/major-ktlint branch September 20, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant