Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed StatelessClassesRule #1741

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fixed StatelessClassesRule #1741

merged 1 commit into from
Sep 21, 2023

Conversation

nulls
Copy link
Member

@nulls nulls commented Sep 21, 2023

What's done:

  • removed usage of copyElement
  • reused ASTFactory

It's part of #1737

### What's done:
- removed usage of copyElement
- reused ASTFactory

It's part of 1737
@nulls nulls added bug Something isn't working tests Improve testing labels Sep 21, 2023
@nulls nulls self-assigned this Sep 21, 2023
@nulls nulls added this to the 2.0.0 milestone Sep 21, 2023
Copy link
Member

@kgevorkyan kgevorkyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, why ktlint start to run itself for 3 times?
we cant change this behavior?

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #1741 (92a3be6) into master (dd5542b) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1741      +/-   ##
============================================
+ Coverage     75.00%   75.12%   +0.12%     
  Complexity     2274     2274              
============================================
  Files           126      126              
  Lines          8233     8233              
  Branches       2066     2067       +1     
============================================
+ Hits           6175     6185      +10     
+ Misses         1142     1132      -10     
  Partials        916      916              
Files Changed Coverage Δ
...set/rules/chapter6/classes/StatelessClassesRule.kt 83.72% <100.00%> (+23.25%) ⬆️

@nulls
Copy link
Member Author

nulls commented Sep 21, 2023

btw, why ktlint start to run itself for 3 times? we cant change this behavior?

yes, ktlint start to run itseft and 3 times is hardcoded unfortunately

@nulls
Copy link
Member Author

nulls commented Sep 21, 2023

btw, why ktlint start to run itself for 3 times? we cant change this behavior?

but here the problem is in copyElement. Kotlin 1.9 doesn't allow it

@nulls nulls enabled auto-merge (squash) September 21, 2023 11:13
@nulls nulls merged commit 2e563f2 into master Sep 21, 2023
31 checks passed
@nulls nulls deleted the feature/fix-tests#1737 branch September 21, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants