Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: respect tags when saving Test Suites #966

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Jul 26, 2022

Follow up for #925. We now send tags in TestSuiteDtos, but don't use them in findOne before saving tests. This leads to errors after data is initially saved and findOne starts to return more than one entry.

Also specifies save-core version to 0.3.2 unitl saveourtool/save-cli#429 is implemented. Then it should be integrated in save-cloud (e.g. we should check how cliArgs in orhcestrator will be constructed)

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #966 (1085cc7) into master (79112b5) will increase coverage by 0.20%.
The diff coverage is 50.00%.

❗ Current head 1085cc7 differs from pull request most recent head 8762d93. Consider uploading reports for the commit 8762d93 to get more accurate results

@@             Coverage Diff              @@
##             master     #966      +/-   ##
============================================
+ Coverage     51.58%   51.79%   +0.20%     
  Complexity      600      600              
============================================
  Files           148      148              
  Lines          4598     4599       +1     
  Branches        466      467       +1     
============================================
+ Hits           2372     2382      +10     
+ Misses         2031     2017      -14     
- Partials        195      200       +5     
Impacted Files Coverage Δ
...eourtool/save/backend/service/TestSuitesService.kt 50.00% <50.00%> (-0.73%) ⬇️
...tool/save/frontend/components/views/ProjectView.kt 23.88% <0.00%> (ø)
...save/frontend/components/views/OrganizationView.kt 49.12% <0.00%> (+1.75%) ⬆️
...ts/basic/organizations/ManageGitCredentialsCard.kt 76.92% <0.00%> (+7.69%) ⬆️
...ve/frontend/components/basic/ManageUserRoleCard.kt 57.14% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79112b5...8762d93. Read the comment docs.

@petertrr petertrr enabled auto-merge (squash) July 26, 2022 11:41
@petertrr petertrr merged commit 67fb402 into master Jul 26, 2022
@petertrr petertrr deleted the petertrr-patch-3 branch July 26, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants