-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Currency to only Display Cents When Needed #602
base: master
Are you sure you want to change the base?
Conversation
@mrodriguezg1991 Tagging for review per Mohammed's email. Thank you. |
Hello @cheng-jess , thanks for contributing |
@mrodriguezg1991 It looks like this is failing due to the Amharic cardinal test cases (28-33 in test_am.py)--these don't appear to be related to the cents issue. @cheng-jess what's the purpose of these test cases? I am also interested in getting this issue resolved. 🙂 |
Oh it looks like it's related to @cheng-jess 's other PR here, probably these cases were meant to go there. |
I opened a new PR here which removes the erroneous test cases. |
Fixes #554 by updating base.py
Changes proposed in this pull request:
Status
How to verify this change
Additional notes
Not sure if this issue was a wanted bug fix or feature, but updated base.py to stop cents from being converted to words when not explicitly included in the number input (e.g. handling 100 vs 100.00 differently).