Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile compatible #93

Merged
merged 65 commits into from
Aug 6, 2023
Merged

Mobile compatible #93

merged 65 commits into from
Aug 6, 2023

Conversation

sayansil
Copy link
Owner

@sayansil sayansil commented Mar 12, 2023

Description and Context

Best Practices

  • My code follows the code style of this project.
  • The code base is in a better state after this PR.
  • The level of testing this PR includes is appropriate.
  • I have considered the impact that this change will cause on application performance.

Git requirements

  • I don't have multiple unrelated changes in the same PR.
  • My branch is in sync with latest production branch.

DarkStar1997
DarkStar1997 previously approved these changes Mar 12, 2023
Copy link
Collaborator

@DarkStar1997 DarkStar1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the CMake presets for mobile compatility to this PR.

@DarkStar1997
Copy link
Collaborator

Need to add workflows to add android build jobs with the newly added presets.

@sayansil sayansil merged commit b62dd4e into master Aug 6, 2023
22 checks passed
@sayansil sayansil deleted the mobile-compatible branch August 6, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants