New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celery: More precise typing for Task.replace(...) #165

Merged

kodiakhq merged 1 commit into sbdchd:main from alecbarber:feat/celery-task-replace

Nov 25, 2024

Contributor

alecbarber commented Nov 25, 2024 •

edited

Loading

Resolves #166

Task.replace() either applys the provided signature eagerly, or raises Ignore [1]. Here's a silly example which this PR fixes:

from celery import Celery, Task

app = Celery()

@app.task(bind=True)
def maybe_replace(task: Task, replace: bool) -> int:
    if replace:
        return task.replace(maybe_replace.s(replace=False))   # type: ignore[func-returns-value]
    else:
        return 10

[1] https://github.com/celery/celery/blob/1b35d1d5966614ce36af75808ee21b0d2db6745d/celery/app/task.py#L1105-L1109


          celery: More precise typing for Task.replace(...)

cc12860

sbdchd added the automerge label

kodiakhq bot merged commit 28e067c into sbdchd:main

2 checks passed

Owner

sbdchd commented Nov 26, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels