-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the -jvm-debug and -h flags in the ash template #1630
base: main
Are you sure you want to change the base?
Conversation
At least one commit author (igansperger@cloudera.com, igansperger@cloudera.com) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
At least one commit author (igansperger@cloudera.com, igansperger@cloudera.com) is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
Hi @qwe2, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Interestingly the |
Thanks for tackling this 💪 I'll be on vacation . Maybe @dwickern can take a look 😊 |
I've been a bit busy and wasn't sure what to do about Java 8 compat, but I ended up adding some checks so that |
This should fix issues like #1523