Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the -jvm-debug and -h flags in the ash template #1630

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

qwe2
Copy link

@qwe2 qwe2 commented Aug 22, 2024

This should fix issues like #1523

@lightbend-cla-validator

Hi @qwe2,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@qwe2
Copy link
Author

qwe2 commented Aug 22, 2024

Interestingly the addDebugger syntax from bash-template is only compatible with Java 9+, but the GH workflow is still pulling JDK 1.8. java_version_check also checks for Java 8, not 9. Not sure if this is intentional...

@muuki88
Copy link
Contributor

muuki88 commented Aug 22, 2024

Thanks for tackling this 💪

I'll be on vacation . Maybe @dwickern can take a look 😊

@qwe2
Copy link
Author

qwe2 commented Nov 28, 2024

I've been a bit busy and wasn't sure what to do about Java 8 compat, but I ended up adding some checks so that -jvm-debug works on both ash and bash for Java 8 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants