Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update GitHub Actions to setup-java #1646

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Nov 9, 2024

Problem

setup-scala is deprecated since setup-java can set up the JDK, and configure the cache.

Solution

This brings up the GitHub Actions to a modern set, and collapsing down the duplicated settings for the scripted jobs by using a matrix instead.

@eed3si9n eed3si9n requested review from muuki88 and dwickern November 9, 2024 22:29
muuki88
muuki88 previously approved these changes Nov 10, 2024
.github/workflows/validate-pr.yml Outdated Show resolved Hide resolved
@muuki88
Copy link
Contributor

muuki88 commented Nov 10, 2024

Thanks a lot @eed3si9n 🙏😊

@eed3si9n eed3si9n merged commit 878d38d into sbt:master Nov 10, 2024
16 checks passed
@eed3si9n eed3si9n deleted the wip/actions branch November 10, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants