Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make symlink creation failure an error again
Ignoring OSError was introducted in commit 737eaa3 likely to ignore EEXISTS errors when another thread had already created an identical symlink due to a race condition. While this was never good because the underlying race condition would still be there, it also made us blind to other errors such as missing permissions or exhaustion of inodes on the target file system. Using tempfile.mkdtemp to create the workdir should reliably avoid any race condition now and make this selective blindspot unnecessary (as long as the same sample isn't analysed by multiple threads - whoa).
- Loading branch information