Apply suggestions from code review

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
scala-js · Sep 29, 2023 · 23c2c77 · 23c2c77
1 parent 1cc5447
commit 23c2c77
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/dom/src/main/scala/org/scalajs/dom/NDEFRecordInit.scala b/dom/src/main/scala/org/scalajs/dom/NDEFRecordInit.scala
@@ -13,7 +13,7 @@ trait NDEFRecordInit extends js.Object {
   /** Contains the data to be transmitted. It can be a string object or literal, an ArrayBuffer, a TypedArray, a
     * DataView, or an array of nested records.
     */
-  def data: js.UndefOr[
+  var data: js.UndefOr[
       String |
         js.typedarray.DataView |
         js.typedarray.ArrayBuffer |
@@ -23,18 +23,18 @@ trait NDEFRecordInit extends js.Object {
   ] = js.undefined
 
   /** A string specifying the record's encoding. */
-  def encoding: js.UndefOr[String] = js.undefined
+  var encoding: js.UndefOr[String] = js.undefined
 
   /** A developer-defined identifier for the record. */
-  def id: js.UndefOr[String] = js.undefined
+  var id: js.UndefOr[String] = js.undefined
 
   /** A valid language tag according to [RFC 5646: Tags for Identifying Languages (also known as BCP
     * 47)](https://datatracker.ietf.org/doc/html/rfc5646).
     */
-  def lang: js.UndefOr[String] = js.undefined
+  var lang: js.UndefOr[String] = js.undefined
 
   /** A valid MIME type. */
-  def mediaType: js.UndefOr[String] = js.undefined
+  var mediaType: js.UndefOr[String] = js.undefined
 
   /** A string indicating the type of data stored in data.
     *
@@ -47,5 +47,5 @@ trait NDEFRecordInit extends js.Object {
     *   - "unknown" - The record type is not known.
     *   - "URL" - A URL as defined by the NDEF-URI specification.
     */
-  def recordType: js.UndefOr[String] = js.undefined
+  var recordType: js.UndefOr[String] = js.undefined
 }
diff --git a/dom/src/main/scala/org/scalajs/dom/NDEFScanOptions.scala b/dom/src/main/scala/org/scalajs/dom/NDEFScanOptions.scala
@@ -5,5 +5,5 @@ import scala.scalajs.js
 trait NDEFScanOptions extends js.Object {
 
   /** An AbortSignal that allows the current write operation to be canceled. */
-  def `signal`: js.UndefOr[AbortSignal] = js.undefined
+  var `signal`: js.UndefOr[AbortSignal] = js.undefined
 }
diff --git a/dom/src/main/scala/org/scalajs/dom/NDEFWriteOptions.scala b/dom/src/main/scala/org/scalajs/dom/NDEFWriteOptions.scala
@@ -6,9 +6,9 @@ import scala.scalajs.js
 trait NDEFWriteOptions extends js.Object {
 
   /** A boolean value specifying whether or not existing records should be overwritten, if such exists. */
-  def `overwrite`: Boolean
+  var `overwrite`: Boolean
 
   /** An AbortSignal that allows the current write operation to be canceled. */
-  def `signal`: js.UndefOr[AbortSignal] = js.undefined
+  var `signal`: js.UndefOr[AbortSignal] = js.undefined
 
 }