Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BroadcastChannel #817

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Add BroadcastChannel #817

merged 2 commits into from
Sep 23, 2023

Conversation

armanbilge
Copy link
Member

zetashift
zetashift approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't even know this functionality existed, it sounds great!

zetashift
zetashift reviewed Sep 23, 2023
View reviewed changes
dom/src/main/scala/org/scalajs/dom/webgl/BroadcastChannel.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, one question, why is this located in the webgl folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great question 😂

@armanbilge armanbilge merged commit f0c4f15 into main Sep 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetashift zetashift zetashift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @zetashift