-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade() whenDefined() to CustomElementRegistry #831
Open
cyz1901
wants to merge
5
commits into
scala-js:main
Choose a base branch
from
cyz1901:update_CustomiElementRegistry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
58b60af
add upgrade whenDefined to CustomElementRegistry
cyz1901 f6df225
add get and getName function
cyz1901 a338252
Update dom/src/main/scala/org/scalajs/dom/CustomElementRegistry.scala
cyz1901 2b1da95
Update dom/src/main/scala/org/scalajs/dom/CustomElementRegistry.scala
cyz1901 b333d61
format
cyz1901 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -11,11 +11,29 @@ import scala.scalajs.js.annotation._ | |||||
|
||||||
/** The CustomElementRegistry interface provides methods for registering custom elements and querying registered | ||||||
* elements. To get an instance of it, use the window.customElements property. | ||||||
* https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry | ||||||
*/ | ||||||
@js.native | ||||||
@JSGlobal | ||||||
abstract class CustomElementRegistry extends js.Object { | ||||||
|
||||||
/** Returns the constructor for a previously-defined custom element. */ | ||||||
def get(name: String): js.Dynamic | ||||||
cyz1901 marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
/** Returns the name for a previously-defined custom element. | ||||||
* @param constructor | ||||||
* Constructor for the custom element. | ||||||
*/ | ||||||
def getName(constructor: js.Dynamic): String | ||||||
cyz1901 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
/** Defines a new custom element. */ | ||||||
def define(name: String, constructor: js.Dynamic, options: ElementDefinitionOptions = js.native): Unit | ||||||
|
||||||
/** Upgrades a custom element directly, even before it is connected to its shadow root. */ | ||||||
def upgrade(root: Node): Unit | ||||||
|
||||||
/** Returns an empty Promise that resolves when a custom element becomes defined with the given name. If such a custom | ||||||
* element is already defined, the returned promise is immediately fulfilled. | ||||||
*/ | ||||||
def whenDefined(name: String): js.Promise[Any] | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please copy the doc from here.
Suggested change
|
||||||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.