Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Mill script from com-lihaoyi/mill for the Docker image #3512

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Use Mill script from com-lihaoyi/mill for the Docker image #3512

merged 1 commit into from
Dec 30, 2024

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Dec 30, 2024

@fthomas fthomas added the build label Dec 30, 2024
@fthomas fthomas added this to the 0.32.1 milestone Dec 30, 2024
@fthomas fthomas requested a review from lefou December 30, 2024 13:29
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (3522159) to head (39d994f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3512   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         171      171           
  Lines        3530     3530           
  Branches      332      332           
=======================================
  Hits         3165     3165           
  Misses        365      365

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lefou
lefou approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fthomas fthomas merged commit fa630e3 into main Dec 30, 2024
12 checks passed
@fthomas fthomas deleted the topic/update-mill-script-location branch December 30, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandrohdezma alejandrohdezma alejandrohdezma approved these changes

@lefou lefou lefou approved these changes

Assignees
No one assigned
Labels
build dependency-update
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fthomas @lefou @alejandrohdezma