Skip to content

Commit

Permalink
Replace backslashes in windows upload (#1067)
Browse files Browse the repository at this point in the history
* Update generate_unique_identifier lambda to use a posix path.

* Update Changelog.md

* add missing requests dependency for windows

* Generate poetry lock file.

* Revert changes of pyproject toml.

---------

Co-authored-by: Michael Büßemeyer <michael.buessemeyer@student.hpi.de>
  • Loading branch information
markbader and MichaelBuessemeyer committed May 13, 2024
1 parent bedd3a3 commit 880a0bc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions webknossos/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ For upgrade instructions, please check the respective _Breaking Changes_ section
### Changed

### Fixed
- Performing `webknossos upload` on a windows machine leaded to loss of directory structure due to backslashes in the relative paths. This was fixed by [1067](https://github.com/scalableminds/webknossos-libs/pull/1067)


## [0.14.21](https://github.com/scalableminds/webknossos-libs/releases/tag/v0.14.21) - 2024-05-07
Expand Down
2 changes: 1 addition & 1 deletion webknossos/webknossos/client/_upload_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def upload_dataset(
},
chunk_size=100 * 1024 * 1024, # 100 MiB
generate_unique_identifier=lambda _,
relative_path: f"{upload_id}/{relative_path}",
relative_path: f"{upload_id}/{relative_path.as_posix()}",
test_chunks=False,
permanent_errors=[400, 403, 404, 409, 415, 500, 501],
client=httpx.Client(timeout=None),
Expand Down

0 comments on commit 880a0bc

Please sign in to comment.