Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use setup-java instead of deprecated olafurpg/setup-scala #183

Merged
merged 2 commits into from
Oct 25, 2023
Merged

use setup-java instead of deprecated olafurpg/setup-scala #183

merged 2 commits into from
Oct 25, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 25, 2023

No description provided.

julienrf
julienrf reviewed Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xuwei-k! I would also use that opportunity to use the caching capabilities of setup-java, see my comment below.

.github/workflows/ci.yml Show resolved Hide resolved
@xuwei-k xuwei-k marked this pull request as ready for review October 25, 2023 07:12
@julienrf julienrf merged commit 5aff39a into scalacenter:main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @julienrf