Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: deduplicate reports #7048

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improvement: deduplicate reports #7048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mtags-shared/src/main/scala/scala/meta/internal/metals/ReportContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import scala.util.matching.Regex
import scala.meta.internal.metals.utils.LimitedFilesManager
import scala.meta.internal.metals.utils.TimestampedFile
import scala.meta.internal.mtags.CommonMtagsEnrichments._
import scala.meta.internal.mtags.MD5

trait ReportContext {
def unsanitized: Reporter
Expand Down Expand Up @@ -235,7 +236,11 @@ case class Report(
def fullText(withIdAndSummary: Boolean): String = {
val sb = new StringBuilder
if (withIdAndSummary) {
id.foreach(id => sb.append(s"${Report.idPrefix}$id\n"))
id.orElse(
error.map(error =>
MD5.compute(s"${name}:${error.getStackTrace().mkString("\n")}")
)
).foreach(id => sb.append(s"${Report.idPrefix}$id\n"))
}
path.foreach(path => sb.append(s"$path\n"))
error match {
Expand Down
Loading