fix: added ipam config : push default route true to prevent legacy mode #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I removed unused Gateway DHCP configuration. |
FlorentPoinsaut
force-pushed
the
add-ipam-config
branch
from
d88eb71 to
ec7cd09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Currently the module creates a vpc gateway in legacy mode.
To have full isolation, according to your documentation, it should be in ipam mode.
To achieve that, I added the ipam config push default route to true and to remove dhcp_id which is not compatible.
I didn't choose to add variables to switch between legacy and ipam, tell me if it should be different.
Thank you !