fixup

lib/s3routes/routesUtils.ts

@@ -118,13 +118,10 @@ export const XMLResponseBackend = {
     ) {
         setCommonResponseHeaders(corsHeaders, response, log);
         let error: ArsenalError;
-        let description: string;
         if (errCode instanceof ArsenalError) {
             error = errCode;
-            description = errCode.description;
         } else {
             error = errors.InternalError.customizeDescription(errCode.message);
-            description = errCode.message;
         }
         // early return to avoid extra headers and XML data
         if (error.code === 304) {
@@ -148,10 +145,10 @@ export const XMLResponseBackend = {
         */
         const xml: string[] = [];
         xml.push(
-            '<?xml version="1.0" encoding="UTF-8"?>',
-            '<Error>',
-            `<Code>${errCode.message}</Code>`,
-            `<Message>${description}</Message>`,
+            `<?xml version="1.0" encoding="UTF-8"?>`,
+            `<Error>`,
+            `<Code>${error.message}</Code>`,
+            `<Message>${error.description}</Message>`,
         );
         const invalidArguments = error.metadata.get('invalidArguments') || [];
         invalidArguments.forEach((invalidArgument, index) => {
@@ -161,13 +158,15 @@ export const XMLResponseBackend = {
             xml.push(`<ArgumentValue${counter}>${ArgumentValue}</ArgumentValue${counter}>`);
         });
         xml.push(
-            '<Resource></Resource>',
+            `<Resource></Resource>`,
             `<RequestId>${log.getSerializedUids()}</RequestId>`,
-            '</Error>',
+            `</Error>`,
         );
         const xmlStr = xml.join('');
+        console.log(xmlStr);
         const bytesSent = Buffer.byteLength(xmlStr);
         log.addDefaultFields({ bytesSent });
+        console.log(bytesSent);
         response.writeHead(error.code, {
             'Content-Type': 'application/xml',
             'Content-Length': bytesSent ,

package.json

@@ -52,7 +52,7 @@
     "sproxydclient": "github:scality/sproxydclient#8.1.0",
     "utf8": "^3.0.0",
     "uuid": "^10.0.0",
-    "werelogs": "github:scality/werelogs#8.2.2",
+    "werelogs": "scality/werelogs#8.2.2",
     "xml2js": "^0.6.2"
   },
   "optionalDependencies": {
@@ -89,7 +89,7 @@
     "build": "tsc",
     "prepare": "yarn build",
     "ft_test": "jest tests/functional --testTimeout=120000 --forceExit",
-    "coverage": "nyc --clean jest tests --coverage --testTimeout=120000 --forceExit",
+    "coverage": "nyc --clean jest tests/unit/s3routes/routesUtils/XMLResponseBackend.spec.js --coverage --testTimeout=120000 --forceExit",
     "build_doc": "cd documentation/listingAlgos/pics; dot -Tsvg delimiterStateChart.dot > delimiterStateChart.svg; dot -Tsvg delimiterMasterV0StateChart.dot > delimiterMasterV0StateChart.svg; dot -Tsvg delimiterVersionsStateChart.dot > delimiterVersionsStateChart.svg"
   },
   "private": true,

yarn.lock

@@ -7628,16 +7628,16 @@ webidl-conversions@^7.0.0:
     fast-safe-stringify "^2.1.1"
     safe-json-stringify "^1.2.0"
 
-"werelogs@github:scality/werelogs#8.2.2":
-  version "8.2.2"
-  resolved "https://codeload.github.com/scality/werelogs/tar.gz/e53bef5145697bf8af940dcbe59408988d64854f"
+werelogs@scality/werelogs#8.2.0:
+  version "8.2.0"
+  resolved "https://codeload.github.com/scality/werelogs/tar.gz/7bf334cea94002d118f27d7ec1c7a5af74b51b8d"
   dependencies:
     fast-safe-stringify "^2.1.1"
     safe-json-stringify "^1.2.0"
 
-werelogs@scality/werelogs#8.2.0:
-  version "8.2.0"
-  resolved "https://codeload.github.com/scality/werelogs/tar.gz/7bf334cea94002d118f27d7ec1c7a5af74b51b8d"
+werelogs@scality/werelogs#8.2.2:
+  version "8.2.2"
+  resolved "https://codeload.github.com/scality/werelogs/tar.gz/e53bef5145697bf8af940dcbe59408988d64854f"
   dependencies:
     fast-safe-stringify "^2.1.1"
     safe-json-stringify "^1.2.0"