Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bf(ARSN-361): Handle infinite versionID correctly on version specific PUT for file MD backend #2161

Closed
wants to merge 3 commits into from

Conversation

tmacro
Copy link
Contributor

@tmacro tmacro commented Aug 11, 2023

When passing the infinite versionId (0099999999999999999999RG001) the file backend fails to update the master key if the the infinite version is also the latest version.

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2023

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2023

Incorrect fix version

The Fix Version/s in issue ARSN-361 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.48

  • 7.70.10

  • 8.1.108

Please check the Fix Version/s of ARSN-361, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 11, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this new behavior? Even though it's a test backend, we should ensure we don't introduce regressions. For example a simple test inspired by this one would do: https://github.com/scality/Arsenal/blob/development/7.10/tests/unit/versioning/VersioningRequestProcessor.spec.js#L153

@tmacro
Copy link
Contributor Author

tmacro commented Aug 17, 2023

closing this PR since it is no longer needed

@tmacro tmacro closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants