Bugfix/arsn 368 id and principal on policy hotfix #2173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update lifecycle utils to support * remove `console.log`
…sNoncurrentVersionSupport' into w/7.70/bugfix/ARSN-308/addLifecycleUtilsNoncurrentVersionSupport
- retain metric config types - set asPrometheus as async fn
…m-client' into w/7.70/improvement/ARSN-313-upgrade-prom-client
Use a state machine for cleaner state management in DelimiterVersions listing algo, with Typescript for enhanced type checking Also, fix an inefficiency with listing params generated from the KeyMarker parameter when there is a delimiter: it was listing more keys than necessary when the KeyMarker equals a CommonPrefix.
Add support for null keys in versions listing: - when they exist, output the null keys at the appropriate position in the Versions array - handle KeyMarker/VersionIdMarker appropriately as if the null keys were real versions. This requires the listing to start at the very first version of the next key each time to see the null key, then potentially skip over the versions below VersionIdMarker using skip-scan optimization.
And a markdown file with summary of what the listing algo does
Collecting default metrics should not be the default, should be invoked when needed. This causes build errors when multiple components use Arsenal.
…' into tmp/octopus/w/7.70/improvement/ARSN-315-disable-default-metrics-collection
…n-7-10-46' into w/7.70/improvement/ARSN-315-bump-version-7-10-46
Port the listVersionKeys() helper from the Metadata backend to the BucketFile backend, as a first step towards supporting null keys in BucketFile.
Use "logger.addDefaultFields()" to set bucket, key and options to the logs, which cleans up log calls. Log repair errors with `log.error` unless it's ObjNotFound
Support null keys in BucketFile backend - null keys are the new way to store null versions, where a single database key with a specific empty version ID is used instead of referencing the null version via "nullVersionId" in object metadata. Add relevant unit tests to check the new behavior (those were copied and mechanically adapted from the Metadata repository).
This new attribute will be set whenever a Cloudserver supporting null keys sets the "isNull" attribute to a master key, along with it. The purpose of this attribute is to allow Cloudserver to optimize by not having to check and delete a null versioned key when the null master has "isNull2" set, as it is guaranteed not to exist. We need to introduce a new attribute to keep backward compatibility, the naming is a bit unfortunate but it has the benefit of being short and not too specific to a particular optimization, just stating that it is a "new" null master.
The maximum length should be 2048 characters having 31 characters on the fixed length prefix this explains the 2017 max limit put in the schema (cherry picked from commit 73c6f41)
Signed-off-by: Maha Benzekri <maha.benzekri@scality.com> (cherry picked from commit 9ea39c6)
Hello benzekrimaha,My role is to assist you with the merge of this Status report is not available. |
benzekrimaha
deleted the
bugfix/ARSN-368-id-and-principal-on-policy-hotfix
branch
benzekrimaha
restored the
bugfix/ARSN-368-id-and-principal-on-policy-hotfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.