Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1481 fixes for check run interactions #175

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Apr 23, 2024

No description provided.

@tcarmet tcarmet requested a review from a team as a code owner April 23, 2024 21:46
@bert-e bert-e force-pushed the feature/PTFE-1481-fixes-and-tests branch from d837d0f to 3fa7737 Compare April 25, 2024 21:05
@tcarmet tcarmet changed the title PTFE-1481 ensure private key is bytes PTFE-1481 fixes for check run interactions Apr 25, 2024
@tcarmet tcarmet enabled auto-merge (squash) April 25, 2024 21:19
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.52%. Comparing base (68afcf3) to head (6222d8c).
Report is 2 commits behind head on main.

Files Patch % Lines
bert_e/git_host/github/__init__.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   78.54%   78.52%   -0.03%     
==========================================
  Files          71       71              
  Lines       10073    10077       +4     
==========================================
+ Hits         7912     7913       +1     
- Misses       2161     2164       +3     
Flag Coverage Δ
api-mock 36.82% <42.85%> (-0.01%) ⬇️
server 36.82% <42.85%> (-0.01%) ⬇️
tests-noqueue 76.97% <57.14%> (-0.03%) ⬇️
unittests 36.82% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 43240e3 into main Apr 25, 2024
7 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1481-fixes-and-tests branch April 25, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants