Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-424: api call updated with implicit deny logic #5288

Closed

Conversation

KazToozs
Copy link

@KazToozs KazToozs commented Aug 22, 2023

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?
Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2162

Related issues

PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2162
https://github.com/scality/Vault/pull/2134

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Hello kaztoozs,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Branches have diverged

This pull request's source branch improvement/CLDSRV-424-apicall-auth-update has diverged from
development/8.7 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/8.7 into improvement/CLDSRV-424-apicall-auth-update
  • Rebase improvement/CLDSRV-424-apicall-auth-update onto origin/development/8.7

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@KazToozs KazToozs changed the base branch from development/8.7 to development/7.70 August 24, 2023 11:38
@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-424 contains:

  • 7.70.25

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.70.25

  • 8.6.11

  • 8.7.29

  • 8.8.1

Please check the Fix Version/s of CLDSRV-424, or the target
branch of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants