FT: Logs should not be able to overwrite reserved fields #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulreddy
force-pushed
the
dev/FT/reservedFields
branch
2 times, most recently
from
9b51877
to
c5ff5f6
Compare
rahulreddy
force-pushed
the
dev/FT/reservedFields
branch
from
c5ff5f6
to
6e2ae6b
Compare
| } | ||
|
|
||
| fields.req_id = serializeUids(this.uids); | ||
| this.fields.req_id = serializeUids(this.uids); |
There was a problem hiding this comment.
So you want to update "this" for every log entry ? I'm not sure that's what you actually aim for ? (And I wouldn't see the point)
|
The objectCopy part is a really good thing, but I'm wondering what you tried to do with the fields object, because it looks like a mistake while trying to do something else. |
| */ | ||
| setName(name) { | ||
| this.fields.name = name; | ||
| return name; |
There was a problem hiding this comment.
shouldn't return this instead of name ?
|
I felt |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50