Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.12 #781

Closed
wants to merge 8 commits into from
Closed

Scala 2.13.12 #781

wants to merge 8 commits into from

Conversation

mccartney
Copy link
Collaborator

Fixes #780

@saeltz saeltz self-requested a review September 11, 2023 07:45
@mccartney
Copy link
Collaborator Author

At least one more problem to solve. It looks like they have changed the interface of the (internal) StoreReporter.Info. Unless we find some trick/workaround, we would need to have some conditional code based on Scala minor version (that'd be something to avoid).

@saeltz
Copy link
Collaborator

saeltz commented Sep 11, 2023

This would work:

        reporter.infos.head should matchPattern {
          case info: StoreReporter.Info
              if info.pos == position && info.msg.contains(
                "[scapegoat] [DummyInspection] My default is Error\n  This is explanation."
              ) && info.severity == reporter.ERROR =>

@mccartney
Copy link
Collaborator Author

No time to check it out right now. Feel free to push to this branch.

@saeltz saeltz mentioned this pull request Sep 11, 2023
@SethTisue
Copy link

superseded by #789, looks like

@saeltz saeltz closed this in #789 Sep 18, 2023
@saeltz saeltz deleted the scala-2-13-12 branch August 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala 2.13.12
3 participants