Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKIP level #782

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

eugene-sy
Copy link
Contributor

@eugene-sy eugene-sy commented Sep 9, 2023

refs #646

This one adds the ignore inspection level, allowing another way to suppress unneeded inspections along with disable/enable flags.
The level name looks a bit alien to me, but skip is worse. Let me know if you have a better idea of the name.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (756847b) 87.22% compared to head (523490a) 87.07%.
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   87.22%   87.07%   -0.16%     
==========================================
  Files         141      141              
  Lines        1527     1540      +13     
  Branches      254      268      +14     
==========================================
+ Hits         1332     1341       +9     
- Misses        195      199       +4     
Files Coverage Δ
src/main/scala/com/sksamuel/scapegoat/Level.scala 100.00% <100.00%> (+100.00%) ⬆️
...n/scala/com/sksamuel/scapegoat/Configuration.scala 61.11% <50.00%> (+58.16%) ⬆️
...a/com/sksamuel/scapegoat/io/HtmlReportWriter.scala 0.00% <0.00%> (ø)
...c/main/scala/com/sksamuel/scapegoat/Feedback.scala 88.23% <60.00%> (-5.52%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eugene-sy eugene-sy marked this pull request as ready for review October 12, 2023 18:34
@eugene-sy
Copy link
Contributor Author

@mccartney do you have a moment to take a look? I'd prefer to have it in before I start working on the config file.

Copy link
Collaborator

@mccartney mccartney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any comments. Good stuff.

@mccartney mccartney merged commit c9777af into scapegoat-scala:master Oct 18, 2023
9 checks passed
@eugene-sy eugene-sy deleted the skip-inspection-level branch October 24, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants