Add new inspection: abstract trait #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
- Coverage 88.08% 82.45% -5.64%
==========================================
Files 142 19 -123
Lines 1578 302 -1276
Branches 278 32 -246
==========================================
- Hits 1390 249 -1141
+ Misses 188 53 -135 ☔ View full report in Codecov by Sentry. |
saeltz
reviewed
Oct 16, 2024
src/main/scala-2/com/sksamuel/scapegoat/inspections/traits/AbstractTrait.scala
Outdated
Show resolved
Hide resolved
|
Would you please also fix the ReadmeTest? |
Done |
saeltz
approved these changes
Oct 16, 2024
I keep it in mind, but no in the current request, because I have a little experience work with scala 3, maybe in the next PR |
|
@mccartney, would you issue a new release? |
|
Triggered the release of 3.1.0. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I implemented new inspection: check if trait is abstract (first from this list: #302)